Shop Manager Implementation - #163
Open
ev-th wants to merge 31 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm unsure about the best approach to testing the Application class. My approach was to write unit tests that mocked everything including the Repository classes to test the formatting of the IO, and integration tests to test whether Application was using the Repositories properly.
Mocking the database was time consuming and I'm not sure if it was necessary since the Application class is always initialised only once with the same repository classes, so I'm wondering if rolling the IO formatting testing into the integration tests would have been the best way to go here. Sometimes it feels like I'm going too far with the testing and would like to get a sense of the sweet spot before doing too much and wasting time.
If I had more time, I would have liked to extract some classes out of the Application class since it's getting unwieldy. I would love to get some advice about how to do this, and how to refactor classes like this more generally.