Instagram challenge - #902
Conversation
| @post = Post.new | ||
| end | ||
|
|
||
| def create |
There was a problem hiding this comment.
At the moment I can write a caption without uploading an image. This is then shown on the feed. When I upload an image without a caption it goes to the feed but it is not posted. I think some alerts would be beneficial, telling the user a post has been created or not giving reasons.
| @@ -0,0 +1,27 @@ | |||
| class PostsController < ApplicationController | |||
| def index | |||
| @posts = Post.all.order('created_at DESC') | |||
| @@ -0,0 +1,20 @@ | |||
| class SessionsController < ApplicationController | |||
| end | ||
|
|
||
| def destroy | ||
| session[:user_id] = nil |
There was a problem hiding this comment.
Good way to log a user out, clean and simple
| @@ -0,0 +1,82 @@ | |||
| class Users::RegistrationsController < Devise::RegistrationsController | |||
There was a problem hiding this comment.
When signing up I intentionally tried to put password different to confirm password. It stopped me from signing up but didnt say way, might be good to tell users why the sign up is failing. I noticed it was also failing for having a username and email set to "1". Is there a check for uniqueness and min lengths here or format?
chris-clement
left a comment
chris-clement
left a comment
There was a problem hiding this comment.
Really nice work! Very high standard of CSS used, I like the sign up and login page. I would add more alerts and notices to tell the user why they are unable to signup and login e.g. email format is invalid, username too short, password and confirm password dont match. Same for creating a post. I think this is a strong start given this is the first weekend working on this. The nav bar looks good and would benefit from being expanded. Few comments below but looks very good and works well.
2 participants
No description provided.