Bowling JavaScript challenge - #1623
Open
snptrs wants to merge 40 commits into
Open
Conversation
#Conflicts: # package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is working (although I think there may still be some slightly janky frame-10 edge cases).
I created a frontend, which I've deployed to Glitch for testing: https://sp-bowling-scorecard.glitch.me
I wanted to try creating it without any client-side JavaScript, so all the processing happens server-side.
The unit tests are pretty comprehensive. Integration testing and mocking of the user interface, not so much.
As much as possible, I tried to do a direct translation of Ruby into JS. Although this works, I've ended up creating some horrible code to workaround things that weren't functioning properly. Next steps would be to do a complete refactor and simplify some of the logic. I suspect I could remove at least a quarter of the code.