-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[WIKI-538] chore: common description component #7785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6c38bed
chore: common description input component
aaryan610 31f3a81
chore: replace existing description input components
aaryan610 670e986
fix: await for update calls
aaryan610 d678c00
refactor: handle fallback values for description states and form data
aaryan610 243f4a6
fix: merge conflicts resolved from preview
aaryan610 027fd02
fix: import statements
aaryan610 bc94ace
chore: add workspaceDetails check
aaryan610 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
11 changes: 9 additions & 2 deletions
11
apps/web/app/(all)/[workspaceSlug]/(settings)/settings/(workspace)/sidebar.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
apps/web/core/components/editor/rich-text/description-input/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export * from "./root"; |
33 changes: 33 additions & 0 deletions
33
apps/web/core/components/editor/rich-text/description-input/loader.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| // plane imports | ||
| import { Loader } from "@plane/ui"; | ||
| import { cn } from "@plane/utils"; | ||
|
|
||
| type Props = { | ||
| className?: string; | ||
| }; | ||
|
|
||
| export const DescriptionInputLoader: React.FC<Props> = (props) => { | ||
| const { className } = props; | ||
|
|
||
| return ( | ||
| <Loader className={cn("space-y-2", className)}> | ||
| <Loader.Item width="100%" height="26px" /> | ||
| <div className="flex items-center gap-2"> | ||
| <Loader.Item width="26px" height="26px" /> | ||
| <Loader.Item width="400px" height="26px" /> | ||
| </div> | ||
| <div className="flex items-center gap-2"> | ||
| <Loader.Item width="26px" height="26px" /> | ||
| <Loader.Item width="400px" height="26px" /> | ||
| </div> | ||
| <Loader.Item width="80%" height="26px" /> | ||
| <div className="flex items-center gap-2"> | ||
| <Loader.Item width="50%" height="26px" /> | ||
| </div> | ||
| <div className="border-0.5 absolute bottom-2 right-3.5 z-10 flex items-center gap-2"> | ||
| <Loader.Item width="100px" height="26px" /> | ||
| <Loader.Item width="50px" height="26px" /> | ||
| </div> | ||
| </Loader> | ||
| ); | ||
| }; | ||
245 changes: 245 additions & 0 deletions
245
apps/web/core/components/editor/rich-text/description-input/root.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,245 @@ | ||
| "use client"; | ||
|
|
||
| import { useCallback, useEffect, useState, useRef } from "react"; | ||
| import { debounce } from "lodash-es"; | ||
| import { observer } from "mobx-react"; | ||
| import { Controller, useForm } from "react-hook-form"; | ||
| // plane imports | ||
| import type { EditorRefApi, TExtensions } from "@plane/editor"; | ||
| import { useTranslation } from "@plane/i18n"; | ||
| import type { EFileAssetType, TNameDescriptionLoader } from "@plane/types"; | ||
| import { getDescriptionPlaceholderI18n } from "@plane/utils"; | ||
| // components | ||
| import { RichTextEditor } from "@/components/editor/rich-text"; | ||
| // hooks | ||
| import { useEditorAsset } from "@/hooks/store/use-editor-asset"; | ||
| import { useWorkspace } from "@/hooks/store/use-workspace"; | ||
| // plane web services | ||
| import { WorkspaceService } from "@/plane-web/services"; | ||
| // local imports | ||
| import { DescriptionInputLoader } from "./loader"; | ||
| // services init | ||
| const workspaceService = new WorkspaceService(); | ||
|
|
||
| type TFormData = { | ||
| id: string; | ||
| description_html: string; | ||
| }; | ||
aaryan610 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| type Props = { | ||
| /** | ||
| * @description Container class name, this will be used to add custom styles to the editor container | ||
| */ | ||
| containerClassName?: string; | ||
| /** | ||
| * @description Disabled, this will be used to disable the editor | ||
| */ | ||
| disabled?: boolean; | ||
| /** | ||
| * @description Disabled extensions, this will be used to disable the extensions in the editor | ||
| */ | ||
| disabledExtensions?: TExtensions[]; | ||
| /** | ||
| * @description Editor ref, this will be used to imperatively attach editor related helper functions | ||
| */ | ||
| editorRef?: React.RefObject<EditorRefApi>; | ||
| /** | ||
| * @description Entity ID, this will be used for file uploads and as the unique identifier for the entity | ||
| */ | ||
| entityId: string; | ||
| /** | ||
| * @description File asset type, this will be used to upload the file to the editor | ||
| */ | ||
| fileAssetType: EFileAssetType; | ||
| /** | ||
| * @description Initial value, pass the actual description to initialize the editor | ||
| */ | ||
| initialValue: string | undefined; | ||
| /** | ||
| * @description Submit handler, the actual function which will be called when the form is submitted | ||
| */ | ||
| onSubmit: (value: string) => Promise<void>; | ||
| /** | ||
| * @description Placeholder, if not provided, the placeholder will be the default placeholder | ||
| */ | ||
| placeholder?: string | ((isFocused: boolean, value: string) => string); | ||
| /** | ||
| * @description projectId, if not provided, the entity will be considered as a workspace entity | ||
| */ | ||
| projectId?: string; | ||
| /** | ||
| * @description Set is submitting, use it to set the loading state of the form | ||
| */ | ||
| setIsSubmitting: (initialValue: TNameDescriptionLoader) => void; | ||
| /** | ||
| * @description SWR description, use it only if you want to sync changes in realtime(pseudo realtime) | ||
| */ | ||
| swrDescription?: string | null | undefined; | ||
| /** | ||
| * @description Workspace slug, this will be used to get the workspace details | ||
| */ | ||
| workspaceSlug: string; | ||
| }; | ||
|
|
||
| /** | ||
| * @description DescriptionInput component for rich text editor with autosave functionality using debounce | ||
| * The component also makes an API call to save the description on unmount | ||
| */ | ||
| export const DescriptionInput: React.FC<Props> = observer((props) => { | ||
| const { | ||
| containerClassName, | ||
| disabled, | ||
| disabledExtensions, | ||
| editorRef, | ||
| entityId, | ||
| fileAssetType, | ||
| initialValue, | ||
| onSubmit, | ||
| placeholder, | ||
| projectId, | ||
| setIsSubmitting, | ||
| swrDescription, | ||
| workspaceSlug, | ||
| } = props; | ||
| // states | ||
| const [localDescription, setLocalDescription] = useState<TFormData>({ | ||
| id: entityId, | ||
| description_html: initialValue?.trim() ?? "", | ||
| }); | ||
| // ref to track if there are unsaved changes | ||
| const hasUnsavedChanges = useRef(false); | ||
| // store hooks | ||
| const { getWorkspaceBySlug } = useWorkspace(); | ||
| const { uploadEditorAsset } = useEditorAsset(); | ||
| // derived values | ||
| const workspaceDetails = getWorkspaceBySlug(workspaceSlug); | ||
| // translation | ||
| const { t } = useTranslation(); | ||
| // form info | ||
| const { handleSubmit, reset, control } = useForm<TFormData>({ | ||
| defaultValues: { | ||
| id: entityId, | ||
| description_html: initialValue?.trim() ?? "", | ||
| }, | ||
| }); | ||
|
|
||
| // submit handler | ||
| const handleDescriptionFormSubmit = useCallback( | ||
| async (formData: TFormData) => { | ||
| await onSubmit(formData.description_html); | ||
| }, | ||
| [onSubmit] | ||
| ); | ||
|
|
||
| // reset form values | ||
| useEffect(() => { | ||
| if (!entityId) return; | ||
| reset({ | ||
| id: entityId, | ||
| description_html: initialValue?.trim() === "" ? "<p></p>" : (initialValue ?? "<p></p>"), | ||
| }); | ||
| setLocalDescription({ | ||
| id: entityId, | ||
| description_html: initialValue?.trim() === "" ? "<p></p>" : (initialValue ?? "<p></p>"), | ||
aaryan610 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }); | ||
| // Reset unsaved changes flag when form is reset | ||
| hasUnsavedChanges.current = false; | ||
| }, [entityId, initialValue, reset]); | ||
|
|
||
| // ADDING handleDescriptionFormSubmit TO DEPENDENCY ARRAY PRODUCES ADVERSE EFFECTS | ||
| // TODO: Verify the exhaustive-deps warning | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| const debouncedFormSave = useCallback( | ||
| debounce(async () => { | ||
| handleSubmit(handleDescriptionFormSubmit)() | ||
| .catch((error) => console.error(`Failed to save description for ${entityId}:`, error)) | ||
| .finally(() => { | ||
| setIsSubmitting("submitted"); | ||
| hasUnsavedChanges.current = false; | ||
| }); | ||
| }, 1500), | ||
| [entityId, handleSubmit] | ||
| ); | ||
|
|
||
| // Save on unmount if there are unsaved changes | ||
| useEffect( | ||
| () => () => { | ||
| debouncedFormSave.cancel(); | ||
|
|
||
| if (hasUnsavedChanges.current) { | ||
| handleSubmit(handleDescriptionFormSubmit)() | ||
| .catch((error) => { | ||
| console.error("Failed to save description on unmount:", error); | ||
| }) | ||
| .finally(() => { | ||
| setIsSubmitting("submitted"); | ||
| hasUnsavedChanges.current = false; | ||
| }); | ||
| } | ||
| }, | ||
| // since we don't want to save on unmount if there are no unsaved changes, no deps are needed | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| [] | ||
| ); | ||
aaryan610 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| if (!workspaceDetails) return null; | ||
|
|
||
| return ( | ||
| <> | ||
| {localDescription.description_html ? ( | ||
| <Controller | ||
| name="description_html" | ||
| control={control} | ||
| render={({ field: { onChange } }) => ( | ||
| <RichTextEditor | ||
| editable={!disabled} | ||
| ref={editorRef} | ||
| id={entityId} | ||
| disabledExtensions={disabledExtensions} | ||
| initialValue={localDescription.description_html ?? "<p></p>"} | ||
| value={swrDescription ?? null} | ||
| workspaceSlug={workspaceSlug} | ||
| workspaceId={workspaceDetails.id} | ||
| projectId={projectId} | ||
| dragDropEnabled | ||
| onChange={(_description, description_html) => { | ||
| setIsSubmitting("submitting"); | ||
| onChange(description_html); | ||
| hasUnsavedChanges.current = true; | ||
| debouncedFormSave(); | ||
| }} | ||
| placeholder={placeholder ?? ((isFocused, value) => t(getDescriptionPlaceholderI18n(isFocused, value)))} | ||
| searchMentionCallback={async (payload) => | ||
| await workspaceService.searchEntity(workspaceSlug?.toString() ?? "", { | ||
| ...payload, | ||
| project_id: projectId, | ||
| }) | ||
| } | ||
aaryan610 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| containerClassName={containerClassName} | ||
| uploadFile={async (blockId, file) => { | ||
| try { | ||
| const { asset_id } = await uploadEditorAsset({ | ||
| blockId, | ||
| data: { | ||
| entity_identifier: entityId, | ||
| entity_type: fileAssetType, | ||
| }, | ||
| file, | ||
| projectId, | ||
| workspaceSlug, | ||
| }); | ||
| return asset_id; | ||
| } catch (error) { | ||
| console.log("Error in uploading asset:", error); | ||
| throw new Error("Asset upload failed. Please try again later."); | ||
| } | ||
| }} | ||
| /> | ||
| )} | ||
| /> | ||
| ) : ( | ||
| <DescriptionInputLoader /> | ||
| )} | ||
| </> | ||
| ); | ||
| }); | ||
aaryan610 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.