Add Initial Support for Cecotec Readywarm 8400 #2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make-all
reviewed
Dec 28, 2024
custom_components/tuya_local/devices/cecotec_readywarm_8400.yaml
Outdated
Show resolved
Hide resolved
custom_components/tuya_local/devices/cecotec_readywarm_8400.yaml
Outdated
Show resolved
Hide resolved
make-all
added a commit
to stquinn/tuya-local
that referenced
this pull request
Dec 28, 2024
- naming tweaks - use lower case cancel in timer to use translations - use comfort instead of auto to use translations - mark some duplicate hvac_modes hidden to ensure consistent behaviour - remove redundant readonly marking on inherently read-only attribute PR make-all#2701
stquinn
commented
Dec 28, 2024
custom_components/tuya_local/devices/cecotec_readywarm_8400.yaml
Outdated
Show resolved
Hide resolved
make-all
added a commit
that referenced
this pull request
Dec 30, 2024
When a hidden mapping maps to the same dps_val as a normal mapping, the normal mapping should be used. But in the previous code, the hidden mapping could be returned from _find_map_for_value then filtered out later (but only if the hidden marking was on the map, not an embedded condition). Instead, do the filtering inside _find_map_for_value, and improve the logic so that hidden at the map level does not hide all the conditions within, as that is used in some more complex conditional mappings. Also take into account available attributes. PR #2701
stquinn
force-pushed
the
feature/cecotec_readywarm_support
branch
from
9ed1b45 to
e4f669a
Compare
|
@make-all Just seen your commit. Let me test with that as removing the "Off Preset" doesnt actually work as well as I would like. There are a piece of the UI that says null. I will test with your changes and see how that works. |
make-all
reviewed
Dec 30, 2024
custom_components/tuya_local/devices/cecotec_readywarm_8400.yaml
Outdated
Show resolved
Hide resolved
…itial default DP1 value before Preset contraints are evaluated
make-all
reviewed
Jan 3, 2025
custom_components/tuya_local/devices/cecotec_readywarm_8400.yaml
Outdated
Show resolved
Hide resolved
custom_components/tuya_local/devices/cecotec_readywarm_8400.yaml
Outdated
Show resolved
Hide resolved
…e OFF preset visible
- merge primary_entity and secondary_entities to a single list - split product name ready for use in device info fields
make-all
added a commit
that referenced
this pull request
Jan 4, 2025
- minor tweak to follow HA naming convention for devices.
jlikeme
added a commit
to jlikeme/tuya-local
that referenced
this pull request
Jan 7, 2025
* main: (1374 commits) Products cleanup: Q-S Silvercrest kettle: assume boil operation when warm dp is missing. Device config: remove unused local variable Device config: reduce log verbosity Bump tinytuya dependency to 1.16.0 Products cleanup: N-P Products cleanup: L-M Products cleanup: J-K Gautone PG103: use events for alarm and power warnings Products cleanup: H-I ESP Fort smartplug: fix indentation Products cleanup: E-G Docs for PR make-all#2701 Cecotec ReadyWarm 8400: apply new config format changes Revert Fan Only to be standard constraint rather than default and make OFF preset visible Add back 'Off' Preset Mode, remove DP1 'off' constraint and set an initial default DP1 value before Preset contraints are evaluated Update Preset Modes to remove the off preset as per PR conversation Fix Cancel Timer Functionality Removed empty lines Added new line to end of file ... # Conflicts: # custom_components/tuya_local/manifest.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Support for Cecotec Readywarm 8400 Bladeless Heater.
https://www.amazon.co.uk/Consumption-Bladeless-Connected-Oscillation-Security/dp/B08LNQJTT4