Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add workflow to publish the package in github #27

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

deepak-khetwal-e
Copy link

No description provided.

Copy link

@carlos-verdes carlos-verdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you changed the package name to be scoped, do we have other packages with similar scope?

If this is the first what do you think if we rename it to @maf (shorter)

Also I understand the PR failed because there are 2 CI warnings (nullable values), nothing related with the pipeline right?

After clarification I think we can merge.

@carlos-verdes carlos-verdes merged commit 4aa1a3c into next Nov 19, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants