Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: maf-img component #19

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

abu-seini-maf
Copy link

No description provided.

Copy link

@carlos-verdes carlos-verdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments

Comment on lines 48 to 49
logo: true,
'logo--rtl': isRtl

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we rename this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, i missed it, will adjust and re-push

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should have classes to identify if anchor is there or not

src/components/mf-img/mf-img.styles.ts Show resolved Hide resolved
src/shoelace.ts Show resolved Hide resolved
Copy link

@carlos-verdes carlos-verdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and merging

@carlos-verdes carlos-verdes changed the title Feat/mf img feat: maf-img component Nov 12, 2024
@carlos-verdes carlos-verdes merged commit d69e387 into majidalfuttaim:next Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants