Feat/mf navigation #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <mf-nav-item>Option 1</mf-nav-item> | ||
| <mf-nav-item highlight>Highlighted</mf-nav-item> | ||
| <mf-nav-item disabled>Disabled</mf-nav-item> | ||
| <mf-nav-item loading>Loading</mf-nav-item> |
There was a problem hiding this comment.
let's put a comment to review aria-busy
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-busy
| <slot name="suffix" part="suffix" class="nav-item__suffix"></slot> | ||
|
|
||
| <span part="subnav-icon" class="nav-item__chevron"> | ||
| <sl-icon name=${isRtl ? 'chevron-down' : 'chevron-down'} library="system" aria-hidden="true"></sl-icon> |
There was a problem hiding this comment.
maybe we don't need control for rtl
| const isSubnavExpanded = this.subnavController.isExpanded(); | ||
|
|
||
| return html` | ||
| <a |
There was a problem hiding this comment.
not sure I would use anchor as a root element, just put a note in the code to review later
carlos-verdes
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.