Feat/mf header #16
Closed
Feat/mf header #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feat/navigation item component
Update mf-nav-item.styles.ts
There was a problem hiding this comment.
PR is too big for a full review, I suggest to do next:
- remove figma related commits that were deleted previously (mentioned on my comments)
- discuss about the need of a mf-actions component and keep it/remove it from the PR after we agree on this point
- merge the rest of the code and do smaller refactors when needed (for example we will review the CSS variables later)
docs/assets/scripts/figma-button.js
Outdated
| @@ -0,0 +1,24 @@ | |||
| window.addEventListener('load', function (event) { | |||
| @@ -0,0 +1,52 @@ | |||
| --- | |||
There was a problem hiding this comment.
What is the difference between this and a menu component?
I feel we don't need this component
docs/pages/components/mf-header.md
Outdated
| <mf-navigation slot="subnav" wide> | ||
| <mf-nav-item value="sale" highlight>Sale</mf-nav-item> | ||
| <mf-nav-item value="new-in" wide>New In | ||
| <mf-navigation slot="subnav" wide> |
There was a problem hiding this comment.
what is the html translation to this sub navigation element?
Comment on lines
120
to
125
| `, | ||
| figma: ` | ||
| <svg id="Layer_1" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 200 300" width="1667" height="2500"><style type="text/css">.st0{fill:#0acf83}.st1{fill:#a259ff}.st2{fill:#f24e1e}.st3{fill:#ff7262}.st4{fill:#1abcfe}</style><title>Figma.logo</title><desc>Created using Figma</desc><path id="path0_fill" class="st0" d="M50 300c27.6 0 50-22.4 50-50v-50H50c-27.6 0-50 22.4-50 50s22.4 50 50 50z"/><path id="path1_fill" class="st1" d="M0 150c0-27.6 22.4-50 50-50h50v100H50c-27.6 0-50-22.4-50-50z"/><path id="path1_fill_1_" class="st2" d="M0 50C0 22.4 22.4 0 50 0h50v100H50C22.4 100 0 77.6 0 50z"/><path id="path2_fill" class="st3" d="M100 0h50c27.6 0 50 22.4 50 50s-22.4 50-50 50h-50V0z"/><path id="path3_fill" class="st4" d="M200 150c0 27.6-22.4 50-50 50s-50-22.4-50-50 22.4-50 50-50 50 22.4 50 50z"/></svg> | ||
| `, | ||
| 'figma-mono': ` | ||
| <svg viewBox="0.5 0.5 171.1 246" xmlns="http://www.w3.org/2000/svg" width="1737" height="2500" fill="currentColor"><path d="M150.7 85c12.5-8.2 20.8-22.4 20.8-38.5 0-25.4-20.7-46-46-46h-79C21.1.5.5 21.2.5 46.5.5 62.6 8.8 76.8 21.3 85 8.8 93.2.5 107.4.5 123.5s8.3 30.3 20.8 38.5C8.8 170.2.5 184.4.5 200.5c0 25.4 20.8 46 46.3 46 25.8 0 46.8-20.9 46.8-46.5v-42.5c8.2 7.4 19.1 12 31 12h1c25.4 0 46-20.7 46-46-.1-16.1-8.4-30.3-20.9-38.5zM78.5 200c0 17.3-14.2 31.5-31.7 31.5-17.2 0-31.2-13.9-31.2-31s13.9-30.9 30.9-31h32zm0-45.5h-32c-17.1 0-30.9-13.9-30.9-31s13.9-31 31-31h32v62zm0-77h-32c-17.1 0-31-13.9-31-31s13.9-31 31-31h32zm15-62h32c17.1 0 31 13.9 31 31s-13.9 31-31 31h-32zm32 139h-1c-17.1 0-31-13.9-31-31s13.9-31 31-31h1c17.1 0 31 13.9 31 31s-13.9 31-31 31z"/></svg> |
Comment on lines
+18
to
+25
| font-family: var(--sl-font-sans); | ||
| font-size: var(--sl-font-size-medium); | ||
| font-weight: var(--sl-font-weight-normal); | ||
| line-height: var(--sl-line-height-normal); | ||
| letter-spacing: var(--sl-letter-spacing-normal); | ||
| color: var(--sl-color-neutral-700); | ||
| padding: var(--sl-spacing-2x-small) var(--sl-spacing-2x-small); | ||
| transition: var(--sl-transition-fast) fill; |
There was a problem hiding this comment.
I suppose we plan to review CSS variables in a different PR right?
|
I believe this is an old PR, I'm closing without merging to avoid confusion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.