Заменил #include на forward-declarations для уменьшения количества зависимостей#1
Open
avilkinnick wants to merge 41 commits into
Open
Заменил #include на forward-declarations для уменьшения количества зависимостей#1avilkinnick wants to merge 41 commits into
avilkinnick wants to merge 41 commits into
Conversation
1) enum с лампами перенесён в .cpp 2) хедэр и .cpp напрямую включают все нужные заголовки 3) добавил к конструктору explicit 4) перенёс реализацию всех функций в .cpp 5) getEPKstate() - константная 6) заменил слот onSafetyTimer на лямбду 7) у таймера устанавливается Qt-шный родитель - сам SafetyDevice 8) в preStep в блоках с code_alsn заменил if на else if
1) убрал лишний конструктор
…ез forward-declare
…trator и TrainHorn через forward-declare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.