Skip to content

fix typo in comment#252

Closed
Espand-Masoon wants to merge 1 commit intomainmatter:mainfrom
Espand-Masoon:patch-2
Closed

fix typo in comment#252
Espand-Masoon wants to merge 1 commit intomainmatter:mainfrom
Espand-Masoon:patch-2

Conversation

@Espand-Masoon
Copy link
Copy Markdown

No description provided.

@hdoordt
Copy link
Copy Markdown
Member

hdoordt commented Jan 28, 2025

Hi @MHMasoon Thanks for helping out! This here's not actually a typo: 255 can't fit in an i8. Do you have any suggestions for improving the wording so it becomes more clear?

@Espand-Masoon
Copy link
Copy Markdown
Author

Hi @hdoordt,
I just made this comment the same as it is in the "solutions" branch. 255u8 can't fit in an i8 but can be converted to it when #[allow(overflowing_literals)] is used; that's what the comment suggests.
As for making it more clear, I don't have any suggestions, but I think the current version encourages students to explore and find the solution. A more explicit comment might spoon-feed them the answer.

@Espand-Masoon Espand-Masoon deleted the patch-2 branch July 5, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants