Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add attrition and battle type to upcoming guild fights view #3130

Closed

Conversation

scibuff
Copy link
Contributor

@scibuff scibuff commented Dec 10, 2024

A little tweak to add the currect sector attrition chance and the battle type to the list of upcoming sectors

image

@Beelzebob6666 Beelzebob6666 changed the base branch from master to beta December 12, 2024 17:44
@outoftheline
Copy link
Collaborator

thank you.
however, you should have started from the beta branch, because the colors have already been implemented there.
as for the attrition percentage: not sure if it makes sense to show it. the percentage will be off for the most part, because most buildings will still be unfinished for a sector in two hours or you'll lose a neighboring sector with buildings in the meantime.

@scibuff
Copy link
Contributor Author

scibuff commented Dec 13, 2024

Sorry didn't realize the beta should have been the base. The percentage can be turned off in the settings, so maybe should jsut disable by default (currently the default is to show it)?

@scibuff
Copy link
Contributor Author

scibuff commented Jan 5, 2025

feature implemented so closing this one

@scibuff scibuff closed this Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants