Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIP-2248: Fix timeout in tracing unit tests. #156

Merged
merged 1 commit into from
Dec 20, 2022
Merged

PIP-2248: Fix timeout in tracing unit tests. #156

merged 1 commit into from
Dec 20, 2022

Conversation

Baliedge
Copy link
Collaborator

@Baliedge Baliedge commented Dec 20, 2022 •
edited
Loading

https://mailgun.atlassian.net/browse/PIP-2248

Closes #154

Fix timeout error occurring in unit tests for tracing package.

Solution was to remove an unnecessary context.WithTimeout() in CloseTracing() because the underlying call to OTel's Shutdown() already has a 10s timeout applied.

@Baliedge Baliedge requested a review from vtopc December 20, 2022 15:11
vtopc
vtopc approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@vtopc vtopc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Baliedge Baliedge merged commit 1d167aa into master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtopc vtopc vtopc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix and enable tracing.TestDummySpan
2 participants
@Baliedge @vtopc