Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and enable tracing.TestDummySpan #154

Closed
vtopc opened this issue Dec 20, 2022 · 1 comment · Fixed by #156
Closed

Fix and enable tracing.TestDummySpan #154

vtopc opened this issue Dec 20, 2022 · 1 comment · Fixed by #156
Assignees
@Baliedge
Labels
broken test

Comments

@vtopc
Copy link
Contributor

vtopc commented Dec 20, 2022 •
edited
Loading 

=== RUN   TestDummySpan
=== RUN   TestDummySpan/Single_dropped_span
time="2022-12-20T12:43:57Z" level=info msg="Initializing OTLP exporter" category=tracing endpoint= protocol=grpc
    dummy_span_test.go:36: PASS:	Shutdown(string)
=== RUN   TestDummySpan/Nested_scope_with_dropped_leaf_span
time="2022-12-20T12:43:57Z" level=info msg="Initializing OTLP exporter" category=tracing endpoint= protocol=grpc
    dummy_span_test.go:65: 
        	Error Trace:	/home/runner/work/holster/holster/tracing/dummy_span_test.go:65
        	Error:      	Received unexpected error:
        	            	context deadline exceeded
        	            	error in tp.Shutdown
        	            	github.com/mailgun/holster/v4/tracing.CloseTracing
        	            		github.com/mailgun/holster/v4/tracing/tracing.go:149
        	            	github.com/mailgun/holster/v4/tracing_test.TestDummySpan.func2
        	            		github.com/mailgun/holster/v4/tracing/dummy_span_test.go:64
        	            	testing.tRunner
        	            		testing/testing.go:1446
        	            	runtime.goexit
        	            		runtime/asm_amd64.s:1594
        	Test:       	TestDummySpan/Nested_scope_with_dropped_leaf_span

https://github.com/mailgun/holster/actions/runs/3740540806/jobs/6349033540

this is not an issue with tracing.CloseTracing() cause TestTracing is not failing.
@vtopc vtopc mentioned this issue Dec 20, 2022
Merged
@vtopc vtopc changed the title Fix tracing.TestDummySpan Fix and enable tracing.TestDummySpan Dec 20, 2022
@Baliedge Baliedge self-assigned this Dec 20, 2022
@Baliedge
Copy link
Collaborator

https://mailgun.atlassian.net/browse/PIP-2248

@Baliedge Baliedge mentioned this issue Dec 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Baliedge Baliedge

Labels
broken test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PIP-2248: Fix timeout in tracing unit tests. mailgun/holster
2 participants
@vtopc @Baliedge