Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use additional volume for upload logs #313

Merged

Conversation

jacderida
Copy link
Contributor

  • d741e1b chore: vary base mount point for striped volume

    I want to use this role to mount a volume on the uploaders too, so the base mount point may be
    different.

    I renamed the role to something a bit more specific that I think captures the purpose.

    I've also taken out a role being applied to the playbook that formatted a disk if we were using AWS
    as the provider. We will hopefully move to AWS soon, but for the time being this was causing a bit
    of confusion and I don't think it will be used; we'll probably need the striped volume setup for AWS
    too.

  • ed609e7 chore: apply retries for service restarts

    I've seen these fail during deployments and unfortunately they will cause the workflow run to fail.

    A simple restart should prevent the failure. These have been applied to other service restarts that
    fail occasionally and they seem to work.

  • 6f5d955 feat: use additional volume for upload logs

    If we want to launch testnets with extended and verbose logging for uploads, we will run out of disk
    space very quickly. For this reason, we will use an additional volume and have the upload logs
    output here.

I want to use this role to mount a volume on the uploaders too, so the base mount point may be
different.

I renamed the role to something a bit more specific that I think captures the purpose.

I've also taken out a role being applied to the playbook that formatted a disk if we were using AWS
as the provider. We will hopefully move to AWS soon, but for the time being this was causing a bit
of confusion and I don't think it will be used; we'll probably need the striped volume setup for AWS
too.
I've seen these fail during deployments and unfortunately they will cause the workflow run to fail.

A simple restart should prevent the failure. These have been applied to other service restarts that
fail occasionally and they seem to work.
If we want to launch testnets with extended and verbose logging for uploads, we will run out of disk
space very quickly. For this reason, we will use an additional volume and have the upload logs
output here.
@jacderida jacderida merged commit ffba920 into maidsafe:main Mar 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant