feat: provide --client-env argument
#308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `--env` variable is renamed to `--node-env` to make way for another variable called `--client-env`, because we also want to be able to configure logging independently on the client.
RolandSherwin
approved these changes
Mar 4, 2025
The `deploy` command now provides this argument so that the client can also be supplied environment variables, which we will mainly use to control logging options. Also renamed references to `SN_LOG` -> `ANT_LOG`.
jacderida
force-pushed
the
feat-vary_client_logging
branch
from
76297d8 to
53dfcc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
02d9ad2 chore: rename
--envarg to--node-envThe
--envvariable is renamed to--node-envto make way for another variable called--client-env, because we also want to be able to configure logging independently on the client.76297d8 feat: provide
--client-envargumentThe
deploycommand now provides this argument so that the client can also be supplied environmentvariables, which we will mainly use to control logging options.