-
Notifications
You must be signed in to change notification settings - Fork 119
EVM Extension and new extension methods #915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+440
β3,086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ethella
reviewed
Aug 12, 2025
Ethella
reviewed
Aug 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just the compatible test and one NIT
joshuascan
commented
Aug 19, 2025
Restore the PNP package that was removed during iframe consolidation. Includes all source files, configuration, and documentation.
Ethella
previously approved these changes
Oct 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ethella
previously approved these changes
Oct 3, 2025
Ethella
previously approved these changes
Oct 3, 2025
Ethella
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π¦ Pull Request
SDK update to implement network switching/iframe consolidation feature.
β Fixed Issues
getPublicAddress
andrevealPrivateKey
for multichain extensionsuser.revealPrivateKey
touser.revealEVMPrivateKey
π¨ Test instructions
[Describe any additional context required to test the PR/feature/bug fix.]
Please π¨ ONLY ADD ONE π¨ of the following labels, failing to do so may lead to adverse versioning of your changes when published:
patch
: Bug Fix?minor
: New Feature?major
: Breaking Change?skip-release
: It's unnecessary to publish this change.Special Note
Please avoid adding any of the
Priority
labels as they conflict with the labels above βοΈπ¦ Published PR as canary version:
Canary Versions
β¨ Test out this PR locally via: