Skip to content

Conversation

joshuascan
Copy link
Member

@joshuascan joshuascan commented Aug 1, 2025

πŸ“¦ Pull Request

SDK update to implement network switching/iframe consolidation feature.

βœ… Fixed Issues

  • Adds new EVM extension and chain switching method
  • Adds getPublicAddress and revealPrivateKey for multichain extensions
  • Renames user.revealPrivateKey to user.revealEVMPrivateKey
    • Only works for EVM chains now
  • Removes @magic-sdk/commons package
  • Removes PNP form

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please 🚨 ONLY ADD ONE 🚨 of the following labels, failing to do so may lead to adverse versioning of your changes when published:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

Special Note

Please avoid adding any of the Priority labels as they conflict with the labels above ☝️

πŸ“¦ Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install [email protected]
# or 
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add [email protected]

@joshuascan joshuascan added the major Increment the major version when merged label Aug 1, 2025
Copy link
Member

@Ethella Ethella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the compatible test and one NIT

@joshuascan joshuascan marked this pull request as ready for review August 15, 2025 23:42
@joshuascan joshuascan requested a review from a team as a code owner August 15, 2025 23:42
@joshuascan joshuascan changed the title EVM Extension and new extension methods [DO NOT MERGE]: EVM Extension and new extension methods Aug 19, 2025
@joshuascan joshuascan self-assigned this Oct 3, 2025
@joshuascan joshuascan changed the title [DO NOT MERGE]: EVM Extension and new extension methods EVM Extension and new extension methods Oct 3, 2025
Ethella
Ethella previously approved these changes Oct 3, 2025
Copy link
Member

@Ethella Ethella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ethella
Ethella previously approved these changes Oct 3, 2025
Ethella
Ethella previously approved these changes Oct 3, 2025
@joshuascan joshuascan added this pull request to the merge queue Oct 3, 2025
Merged via the queue into master with commit 7f8ab55 Oct 3, 2025
6 checks passed
@joshuascan joshuascan deleted the iframe-consolidation branch October 3, 2025 21:16
@Ethella Ethella added the released This issue/pull request has been released. label Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Increment the major version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants