Skip to content

feat(cloning): make cloning concurrency configurable #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

Dodecahedr0x
Copy link
Contributor

@Dodecahedr0x Dodecahedr0x commented Jul 18, 2025

Closes #275

It introduces a parameter to choose the degree of concurrency for cloning accounts on hydration. The default stays the same, but this can now be adjusted

Snippets

In TOML configs:

[ledger.replay]
hydration_concurrency = 10

With the CLI:

cargo run --release -- --replay-hydration-concurrency 10
REPLAY_HYDRATION_CONFIG=10 cargo run --release

@Dodecahedr0x Dodecahedr0x force-pushed the feat/cloning-concurrency branch from 1e94ab6 to 98e249d Compare July 18, 2025 17:00
@Dodecahedr0x Dodecahedr0x marked this pull request as ready for review July 18, 2025 17:04
Copy link
Contributor

@thlorenz thlorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this belongs into AccountsCloneConfig since it is related to ledger replay.
We already have a LedgerConfig and I'd add a field named either of the following there: account_hydration_concurrency|clone_concurrency|hydration_clone_concorrency` (or if you have a better name).

We could either add that directly or (preferred) in a LedgerReplayConfig, so the toml would look similar to.

[ledger]

replay = { account_hydration_concurrency = 20 }

Also please add a fixture here and a test that shows we can parse these new configs from toml properly.

Also please always include a usage example, i.e. a toml snippet, ENV var setting + arg override. That makes it much easier to see what config was added and how.

@Dodecahedr0x
Copy link
Contributor Author

I'm not sure if this belongs into AccountsCloneConfig since it is related to ledger replay. We already have a LedgerConfig and I'd add a field named either of the following there: account_hydration_concurrency|clone_concurrency|hydration_clone_concorrency` (or if you have a better name).

We could either add that directly or (preferred) in a LedgerReplayConfig, so the toml would look similar to.

[ledger]

replay = { account_hydration_concurrency = 20 }

Also please add a fixture here and a test that shows we can parse these new configs from toml properly.

Also please always include a usage example, i.e. a toml snippet, ENV var setting + arg override. That makes it much easier to see what config was added and how.

Addressed in 5a1313b

Copy link
Collaborator

@GabrielePicco GabrielePicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Dodecahedr0x Dodecahedr0x requested a review from thlorenz July 22, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: make concurrency of account cloning during ledger replay configurable
3 participants