- 
                Notifications
    You must be signed in to change notification settings 
- Fork 18
✨ Giving component ownership to world #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Draft
      
      
            notdanilo
  wants to merge
  21
  commits into
  feature/system-updates-components
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
feature/giving-component-ownership-to-world
  
      
      
   
  
    
  
  
  
 
  
      
    base: feature/system-updates-components
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Draft
            
            ✨ Giving component ownership to world #199
                    notdanilo
  wants to merge
  21
  commits into
  feature/system-updates-components
from
feature/giving-component-ownership-to-world
  
      
      
   
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    50355ed    to
    598678a      
    Compare
  
    d806260    to
    b0d65fa      
    Compare
  
    | This implementation will not work. It seems that the account ownership change only occur by the end of an invocation (CPI included). Which means that the assignment of the new owner in the world program is not visible to the CPI. This PR should be closed. | 
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Problem
This PR attempts to change components ownership to the World program, so we don't need to CPI to the world program to change ownernship to the system being executed in the apply instruction.
Solution
IMPORTANT NOTE
This implementation is not working for an unknown cause. The components program account data is being zeroed out as shown in the test.
Run
bolt testto check it.