WIP: 'abduco' completion #181
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unrealapex
commented
Jul 16, 2025
share/completion/abduco
Outdated
Comment on lines
25
to
28
| (-A|-a|-f) | ||
| # FIXME: figure out why this isn't completing | ||
| complete -P "$PREFIX" -- $(abduco | tail -n+2 | awk '{print $NF}') | ||
| ;; |
There was a problem hiding this comment.
What would be the correct way to write this completion?
magicant
reviewed
Jul 22, 2025
share/completion/abduco
Outdated
| (-) | ||
| command -f completion//completeoptions | ||
| ;; | ||
| (-A|-a|-f) |
There was a problem hiding this comment.
If my understanding is correct, session names are specified as the first operand, not as an argument to an option. When completing an operand, $ARGOPT is empty.
Suggested change
| (-A|-a|-f) | |
| ('') |
There was a problem hiding this comment.
Session names are only given as arguments to those three arguments.
There was a problem hiding this comment.
You are right. Every abduco command requires session names given as the first operand unless abduco is given no options or using the -v(print version).
Co-authored-by: WATANABE Yuki <[email protected]>
Co-authored-by: WATANABE Yuki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add completion for
abduco, a session manager.