fix: enforce Subresource Integrity (SRI) verification for FFmpeg core binaries#1576
Open
Abhishek2005-ard wants to merge 10 commits into
Open
fix: enforce Subresource Integrity (SRI) verification for FFmpeg core binaries#1576Abhishek2005-ard wants to merge 10 commits into
Abhishek2005-ard wants to merge 10 commits into
Conversation
|
@Abhishek2005-ard is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
👋 Thanks for your PR, @Abhishek2005-ard!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
github-actions
Bot
added
level:advanced
Contributor
✅ PR Format Check Passed — @Abhishek2005-ardBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a critical security vulnerability where the Subresource Integrity (SRI) verification for the
ffmpeg-coreWebAssembly and JS binaries was being bypassed during initialization.While the
fetchWithIntegrityfunction and theSRI_HASHESdictionary were correctly implemented to secure the FFmpeg binaries against tampering, theloadFFmpegfunction bypassed them entirely by callingtoBlobURLdirectly.Changes Made
src/lib/ffmpeg.tsto utilize the existingfetchWithIntegrityfunction forcoreURLandwasmURL.toBlobURLas the fallback forworkerURLsince it currently does not have an SRI hash associated with it.Impact
This change guarantees that the core FFmpeg WebAssembly binaries loaded in the browser are authentic and haven't been maliciously altered, protecting the application against supply chain attacks or intercepted traffic.
Testing
fetchWithIntegritycorrectly resolves and executes the FFmpeg processes.npm test.next lintsuccessfully without new warnings.close #1575