Skip to content

Add custom template save feature#1572

Open
deepikamishra25 wants to merge 9 commits into
magic-peach:mainfrom
deepikamishra25:new
Open

Add custom template save feature#1572
deepikamishra25 wants to merge 9 commits into
magic-peach:mainfrom
deepikamishra25:new

Conversation

@deepikamishra25

Copy link
Copy Markdown

##Description

Added custom template management functionality for video export settings.

Changes made:

Added ability to save current editor settings as reusable templates.
Added template listing UI in the Templates section.
Added Apply Template functionality to instantly load saved settings.
Added Rename Template functionality.
Added Delete Template functionality.
Implemented localStorage persistence for saved templates.
Improved template state handling and refresh behavior.

##closes 1541

Type of Contribution

  • Bug fix
  • New feature
  • Documentation update
  • Refactor
  • GSSoC contribution

Participant Info

Screen Recording

Screenshot 2026-06-13 093737 Screenshot 2026-06-13 094215

Recording / Loom link: ## Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in
  • This PR is related to a valid issue
  • Screen recording attached above (required for UI/feature/design changes)

@vercel

vercel Bot commented Jun 13, 2026

Copy link
Copy Markdown

@deepikamishra25 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ PR Format Issues — @deepikamishra25

Please fix the following before your PR can be reviewed:

  • ⚠️ Use a conventional PR title. Examples:
    • feat: add dark mode support
    • fix: resolve aria label missing on slider
    • docs: add deployment guide to README
  • ⚠️ No linked issue found. Add Closes #<issue-number> to your PR description.

Push new commits after fixing — this comment will update automatically.

📖 CONTRIBUTING.md

@github-actions github-actions Bot added level:advanced Advanced level - 55 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature type:refactor Code refactor labels Jun 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @deepikamishra25!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added the gssoc'26 GirlScript Summer of Code 2026 label Jun 13, 2026
@Ashvin-KS

Copy link
Copy Markdown

Nice work on the custom template feature! A few issues I spotted:

  1. Critical: page.tsx has content added after the export default — this will cause a syntax error. The new

    block should be inside the existing component.

  2. The �ny type is used extensively in CustomTemplateManager.tsx and emplateStorage.tsx — consider defining proper interfaces for the template data.

  3. No error handling for localStorage operations — if storage is full or disabled, the app will crash.

  4. The @testing-library/react version bump from 14 to 16 is a major version change — make sure tests still pass.

Good feature overall, but the page.tsx issue needs to be fixed before merge.

@deepikamishra25

Copy link
Copy Markdown
Author

Hi @magic-peach , just following up on this PR as it’s been pending for a few days. Whenever you’re available to review, I’d really appreciate your feedback. Thanks in advance for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:advanced Advanced level - 55 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature type:refactor Code refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants