Skip to content

fix: announce ffmpeg loading state #1568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saurabhhhcodes wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −4
Open

fix: announce ffmpeg loading state #1568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions src/components/VideoEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,26 @@ return () => {
};
}, [videoSrc]);

const exportStatusAnnouncement = useMemo(() => {
if (status === "loading-engine") {
return "Loading video processing engine, please wait.";
}

if (status === "exporting") {
return `Export started. Exporting video: ${progress}%`;
}

if (status === "done") {
return "Export complete! Video ready to download.";
}

if (status === "error") {
return `Export failed: ${error}`;
}

return "";
}, [error, progress, status]);

return (
<div className="min-h-screen relative flex flex-col" style={{ background: "var(--bg)" }}>
<ExportOverlay
Expand All @@ -373,10 +393,8 @@ return () => {
/>
<OnboardingTour />

<div aria-live="polite" aria-atomic="true" className="sr-only">
{status === "exporting" && `Exporting video: ${progress}%`}
{status === "done" && "Export complete! Video ready to download."}
{status === "error" && `Export failed: ${error}`}
<div role="status" aria-live="polite" aria-atomic="true" className="sr-only">
{exportStatusAnnouncement}
</div>

<div className="max-w-6xl mx-auto px-4 py-8 pb-6 flex-1 w-full">
Expand Down