fix: resolve URL sync array corruption and btoa emoji crash#1480
Open
divyansha12 wants to merge 3 commits into
Open
fix: resolve URL sync array corruption and btoa emoji crash#1480divyansha12 wants to merge 3 commits into
divyansha12 wants to merge 3 commits into
Conversation
|
@divyansha12 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
✅ PR Format Check Passed — @divyansha12Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Contributor
👋 Thanks for your PR, @divyansha12!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Author
|
Hi @magic-peach, PR is ready for review. The build check is pending Vercel authorization from your side. Let me know if anything needs changing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @magic-peach
Description
This PR resolves two critical URL syncing and sharing bugs that resulted in data corruption and application crashes:
textOverlaysinside theuseEffectURL auto-sync loop inuseVideoEditor.ts. This prevents the complex array from being stringified into"[object Object]", pushing corrupt data into the browser URL and crashing the app upon refresh.btoafailure): Updated theencodeRecipeanddecodeRecipemethods to safely parse UTF-8 characters by wrapping the JSON string withencodeURIComponentandescapebefore passing it tobtoa(). Replaced the directbtoacall inVideoEditor.tsxwith the newly exportedencodeRecipeutility, allowing users to safely share links containing emojis without triggering a fatalDOMException.Related Issue
Closes #1468
Type of Contribution
Participant Info
Screen Recording
Recording / Loom link: [PASTE YOUR LOOM OR VIDEO LINK HERE]
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in