[SERVICE] [FEATURE] Shlink link shortener deployment#186
Open
[SERVICE] [FEATURE] Shlink link shortener deployment#186
Conversation
pinkeen
force-pushed
the
feature-shlink-service
branch
from
4568495 to
cf24d30
Compare
pinkeen
force-pushed
the
feature-shlink-service
branch
from
68147bd to
77ba95c
Compare
krisdante
reviewed
May 12, 2021
Contributor
krisdante
left a comment
krisdante
left a comment
There was a problem hiding this comment.
Shlink support shall not be part of MageOps "core" .
Can you please split it to include the only minimum required set of changes here (extra security group) and handle everything else with extra entry points we have, so a project that needs that can use it as a "plug-in" solution?
krisdante
suggested changes
May 12, 2021
Contributor
krisdante
left a comment
krisdante
left a comment
There was a problem hiding this comment.
Shlink support shall not be part of MageOps "core" .
Can you please split it to include the only minimum required set of changes here (extra security group) and handle everything else with extra entry points we have, so a project that needs that can use it as a "plug-in" solution?
krisdante
force-pushed
the
feature-shlink-service
branch
from
77ba95c to
a7cc959
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.