Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

security-package: Changes for include Google API js file - Admin panel #183

Closed
wants to merge 1 commit into from
Closed

security-package: Changes for include Google API js file - Admin panel #183

wants to merge 1 commit into from

Conversation

engcom-Kilo
Copy link
Contributor

Description (*)

The script - google.com/recaptcha/api.js will include to HTML document only by call.
Removed layout file ReCaptchaAdminUi/view/adminhtml/layout/recaptcha.xml

Fixed Issues (if relevant)

Magento_Admin

Manual testing scenarios (*)

  1. Enable reCaptcha for Admin panel Login or Forgot Password page
  2. Open Admin panel Login or Forgot Password page
  3. Check HTML source

Questions or comments

Contribution checklist (*)

  • Author has signed the Adobe CLA
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@engcom-Kilo
security-package: security-package: Update for reCaptcha.js - changes…
8df2319 
… for include Google API js file - Admin panel
@engcom-Kilo engcom-Kilo added Component: Google reCAPTCHA Issues and Pull Requests related to reCAPTCHA should be marked with this label Component: Admin labels Apr 2, 2020
@engcom-Kilo engcom-Kilo mentioned this pull request Apr 2, 2020
Closed
5 tasks
@engcom-Kilo
Copy link
Contributor Author

Related Pull Request
#176: Update for reCaptcha.js - changes for include Google API js script

@engcom-Delta engcom-Delta self-assigned this Apr 2, 2020
@engcom-Delta
Copy link

✔️ QA passed
The script - google.com/recaptcha/api.js is not loaded after fix
image

@engcom-Foxtrot engcom-Foxtrot mentioned this pull request Apr 3, 2020
Merged
5 tasks
@engcom-Foxtrot
Copy link
Contributor

Please see #191.

@sdzhepa sdzhepa mentioned this pull request Apr 9, 2020
Closed
9 tasks
@lenaorobei lenaorobei deleted the security-package/1time-include-google-api-js-script-adminhtml branch June 10, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naydav naydav Awaiting requested review from naydav

@engcom-Foxtrot engcom-Foxtrot Awaiting requested review from engcom-Foxtrot

Assignees

@engcom-Delta engcom-Delta

Labels
Component: Admin Component: Google reCAPTCHA Issues and Pull Requests related to reCAPTCHA should be marked with this label Progress: review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engcom-Kilo @engcom-Delta @engcom-Foxtrot