Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security-package/issues/170: Renamed error message. #174

Closed
wants to merge 2 commits into from
Closed

security-package/issues/170: Renamed error message. #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4963ee7
security-package/issues/170: Renamed error message.
engcom-Kilo Apr 1, 2020
d9fe7a3
security-package/issues/170: Typo fix.
engcom-Foxtrot Apr 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ReCaptchaContact/Test/Integration/ContactFormTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ public function testPostRequestIfReCaptchaParameterIsMissed()
$this->setConfig(true, 'test_public_key', 'test_private_key');

$this->expectException(InputException::class);
$this->expectExceptionMessage('Can not resolve reCAPTCHA parameter.');
$this->expectExceptionMessage('reCAPTCHA is required.');

$this->checkPostResponse(false);
}
Expand Down
2 changes: 1 addition & 1 deletion ReCaptchaCustomer/Test/Integration/CreateCustomerFormTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ public function testPostRequestIfReCaptchaParameterIsMissed()
$this->setConfig(true, 'test_public_key', 'test_private_key');

$this->expectException(InputException::class);
$this->expectExceptionMessage('Can not resolve reCAPTCHA parameter.');
$this->expectExceptionMessage('reCAPTCHA is required.');

$this->checkPostResponse(false);
}
Expand Down
2 changes: 1 addition & 1 deletion ReCaptchaCustomer/Test/Integration/ForgotPasswordFormTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ public function testPostRequestIfReCaptchaParameterIsMissed()
$this->setConfig(true, 'test_public_key', 'test_private_key');

$this->expectException(InputException::class);
$this->expectExceptionMessage('Can not resolve reCAPTCHA parameter.');
$this->expectExceptionMessage('reCAPTCHA is required.');

$this->checkPostResponse(false);
}
Expand Down
2 changes: 1 addition & 1 deletion ReCaptchaCustomer/Test/Integration/LoginFromTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ public function testPostRequestIfReCaptchaParameterIsMissed()
$this->setConfig(true, 'test_public_key', 'test_private_key');

$this->expectException(InputException::class);
$this->expectExceptionMessage('Can not resolve reCAPTCHA parameter.');
$this->expectExceptionMessage('reCAPTCHA is required.');

$this->checkPostResponse(false);
}
Expand Down
2 changes: 1 addition & 1 deletion ReCaptchaUi/Model/CaptchaResponseResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public function resolve(RequestInterface $request): string
{
$reCaptchaParam = $request->getParam(self::PARAM_RECAPTCHA);
if (empty($reCaptchaParam)) {
throw new InputException(__('Can not resolve reCAPTCHA parameter.'));
throw new InputException(__('reCAPTCHA is required.'));
}
return $reCaptchaParam;
}
Expand Down
2 changes: 1 addition & 1 deletion ReCaptchaUser/Test/Integration/ForgotPasswordFormTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ public function testPostRequestWithSuccessfulReCaptchaValidation()
* @magentoAdminConfigFixture recaptcha_backend/type_invisible/private_key test_private_key
* @magentoAdminConfigFixture recaptcha_backend/type_for/user_forgot_password invisible
* @expectedException \Magento\Framework\Exception\InputException
* @expectedExceptionMessage Can not resolve reCAPTCHA parameter.
* @expectedExceptionMessage reCAPTCHA is required.
*/
public function testPostRequestIfReCaptchaParameterIsMissed()
{
Expand Down
2 changes: 1 addition & 1 deletion ReCaptchaUser/Test/Integration/LoginFormTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ public function testPostRequestIfReCaptchaParameterIsMissed()
// Location header is different than in the successful case
$this->assertRedirect(self::equalTo($this->backendUrl->getUrl('admin')));
$this->assertSessionMessages(
self::equalTo(['Can not resolve reCAPTCHA parameter.']),
self::equalTo(['reCAPTCHA is required.']),
MessageInterface::TYPE_ERROR
);
self::assertFalse($this->auth->isLoggedIn());
Expand Down