security-package: Update for reCaptcha language code. Fixed incorrect language of reCaptcha #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a Frontend, all types, set param hl in call to render.
sdzhepa
added
the
Component: Google reCAPTCHA
naydav
suggested changes
Apr 1, 2020
| @@ -55,8 +55,7 @@ define( | |||
|
|
|||
| element.async = true; | |||
| element.src = 'https://www.google.com/recaptcha/api.js' + | |||
| '?onload=globalOnRecaptchaOnLoadCallback&render=explicit' + | |||
| (this.settings.rendering.lang ? '&hl=' + this.settings.rendering.lang : ''); | |||
| '?onload=globalOnRecaptchaOnLoadCallback&render=explicit'; | |||
There was a problem hiding this comment.
Looks lie we also need to update
https://github.com/magento/security-package/blob/1.0-develop/ReCaptchaUser/view/adminhtml/templates/recaptcha.phtml#L47
There was a problem hiding this comment.
Updated also for Admin panel
…a Admin panel, all types. Reformat code.
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
|
✔️ QA passed |
|
Please see #191. |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Oct 15, 2024
AC-13224: Sync 2.4.8-beta1-develop with 2.4-develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Added hl(language code) param to call for render reCaptcha.
Before language was param of URL https://www.google.com/recaptcha/api.js
Fixed Issues (if relevant)
Fixed incorrect language of reCaptcha.
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)