Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed handle trigger click function error #4363

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

del22123
Copy link
Collaborator

Description

This PR contains the fix for handleTriggerClick function call error in customer login flow when customer signs in from shipping page

Closes #PWA-3381
https://jira.corp.adobe.com/browse/PWA-3381

Acceptance

Verification Stakeholders

Specification

Verification Steps

Step 1: In PWA store view add a product to cart and then go to Checkout page -> Sign In
Step 2: Sign in with an existing customer account

Current result:
Error is thrown 'handletriggerclick() is not a function'

Fix result:
Login will work and user will be logged in at checkout page

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫 A version label is required. A maintainer must add one.
Messages
📖

Associated JIRA tickets: PWA-3381.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against aef1132

Copy link
Contributor

@glo42707 glo42707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants