Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configAggregator.js Sanetize DOM Text Interpreted As HTML #4360

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Shivam7-1
Copy link

Description

Sanitize HTML content using DOMPurify before returning it in richContent. This ensures safe rendering of potentially untrusted HTML, protecting against XSS attacks. The innerHTML of the first child node is sanitized before being returned, improving security.

@Shivam7-1
Copy link
Author

Hii @glo82145 Could Team Please Review This PR
Thanks & Regards

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Dec 6, 2024

Fails
🚫 A version label is required. A maintainer must add one.
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.

🚫 Missing "Verification Steps" section. Please add it back, with detail.
Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against 5495fbe

@Shivam7-1
Copy link
Author

Hii @glo82145 Could Team Please Review This PR
Thanks & Regards

@Shivam7-1
Copy link
Author

Hii @glo42707 @glo82145 Could Team Please Review This PR
Thanks

@Shivam7-1
Copy link
Author

Hii @engcom-Hotel @engcom-Charlie Could Team Please Review This PR also if possible
Thanks

@engcom-Hotel
Copy link

Hey @glo42707 we request you to please look into this.

@glo42707 glo42707 requested a review from glo82145 December 17, 2024 09:32
@Shivam7-1
Copy link
Author

Hii @glo82145 Could you please Review this PR
Thanks

@Shivam7-1
Copy link
Author

Hii @glo82145
I got the Problem as package.json don't have dompurify dependencies install so added
Could You Please Review This again

@Shivam7-1 Shivam7-1 requested a review from glo82145 December 18, 2024 17:54
@Shivam7-1
Copy link
Author

Hey @glo42707 request you to please look into this As I have updated all necessary Changes of there is still it fail Could you Provide some suggestions on it
Regards

@Shivam7-1
Copy link
Author

Ping @glo82145

@Shivam7-1
Copy link
Author

Hii @engcom-Hotel @engcom-Charlie Could Team Please ping Reviewers again
Thanks

@glo42707
Copy link
Contributor

@Shivam7-1 team was reviewing your code and it seems some unit test is failing for same, however let me remind my team for updating which you need to check.

Thanks

@Shivam7-1
Copy link
Author

Hii @glo42707 Thanks For Response i had updated Dependencies with Required File
So I think now it shouldn't fail it I think

If there is issue let me know and why changes are Expected to Resolve of there anything

Thanks

@glo82145
Copy link
Collaborator

glo82145 commented Dec 23, 2024

image

Please check these failing test cases @Shivam7-1

try merging latest develop branch with your branch

@Shivam7-1
Copy link
Author

Shivam7-1 commented Dec 23, 2024

Hii @glo82145 @glo42707 I had sync latest branch Could Check again
Could You Run testing again?
And let me know if there any error because now it Shouldn't give any error
Thanks

@Shivam7-1
Copy link
Author

Shivam7-1 commented Dec 23, 2024

Hii @glo82145 @glo42707 if still there any error Could Team manually test it because I think there shouldm't be any error because I update with all Required file and dependencies which is required you can check it above commits
Thanks

@Shivam7-1
Copy link
Author

Hii @glo42707 Could you please Remind Team again if possible
Thanks

@glo82145
Copy link
Collaborator

PR test fail is still there, however we are looking into cause of these error and will update soon

@Shivam7-1
Copy link
Author

@glo82145 okay let me know if anything required

@Shivam7-1
Copy link
Author

Shivam7-1 commented Dec 23, 2024

Hii @glo82145 @glo42707
here some issue with formating has been fix Could Team check again and run test
here below automated pr-test has passed now
image

@Shivam7-1
Copy link
Author

Hii @glo82145 @glo42707 Thanks For Reviewing
Is there anything else is Required From my side to get this PR merge?

@glo42707
Copy link
Contributor

glo42707 commented Dec 24, 2024

@Shivam7-1
to merge any kind of PR, usually we do internal testing and than if pass than only we proceed to merege however respective changes per PRs get released along with PWA core release date, until unless merchant business is not blockked because of same.

hence request to please allow some time and based on priorities of ticket, it will also get reviewed and merged respectively.

@Shivam7-1
Copy link
Author

@Shivam7-1 to merge any kind of PR, usually we do internal testing and than if pass than only we proceed to merege however respective changes per PRs get released along with PWA core release date, until unless merchant business is not blockked because of same.

hence request to please allow some time and based on priorities of ticket, it will also get reviewed and merged respectively.

Hii @glo42707 Thanks For Response
Is there any timeline or anything of internal testing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants