[TASK] Dynamically set upward server variables#23126
[TASK] Dynamically set upward server variables#23126lewisvoncken wants to merge 1 commit intomagento:2.3-developfrom
Conversation
- MAGENTO_BACKEND_URL based on HTTPS and HTTP_HOST - NODE_ENV based on MAGE_MODE
|
Hi @lewisvoncken. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
orlangur
left a comment
There was a problem hiding this comment.
@lewisvoncken first of all, please provide comprehensive steps for this to be tested.
|
@lewisvoncken I think we can add this to the magento2-upward-connector. And set the needed variables somewhere in the controller before initiation of the upward php |
|
Closing due to inactivity. Feel free to reach me out anytime later if you wish to continue work on this pull request and it will be reopened. |
|
Hi @lewisvoncken, thank you for your contribution! |
Description (*)
To run PWA Studio through Upward there are 2 variables which need to be set.
This PR is related to the upward-php PR magento/upward-php#65
Contribution checklist (*)