Skip to content

Fix integration tests for Magento_Backend and Magento_Bundle #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

simsComputing
Copy link

@simsComputing simsComputing commented Apr 13, 2025

Description (*)

I have fixed all integration tests on Magento_Backend and Magento_Bundle. For the first one it was about rewriting the test to adapt it to the class's new dependencies.
For the second one it was about fixing Magento.

I added fixes for the Magento_CatalogInventory module. It was about fixing the integration with the new ParentItemProcessInterface

Fixed Issues (if relevant)

I cannot access github issues on the mage-os repo. So here is the taiga ticket :


Fix all broken integration tests

But the PR for now does not fix all integration tests. it will be a long way to go.

Manual testing scenarios (*)

First make sure you're in the dev/tests/integration folder. then :

  1. ../../../vendor/bin/phpunit testsuite/Magento/Backend
  2. ../../../vendor/bin/phpunit testsuite/Magento/Bundle
  3. ../../../vendor/bin/phpunit testsuite/Magento/CatalogInventory

You should have 0 broken test

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@simsComputing simsComputing requested a review from a team as a code owner April 13, 2025 17:48
@rhoerr
Copy link
Contributor

rhoerr commented May 20, 2025

Hi! Just wondering, should we have this be a draft PR for now, while you work on more fixes? Or do you want to split your work into multiple PRs, and have us process this one now as-is?

It might be good to do multiple PRs, so that each individual PR is smaller for review. That way we could get things merged faster and more often for you, too.

@humeauantadis
Copy link

Hi @rhoerr , yes of course you're right. Plus i should rewrite the description of the PR since it now contains a few more things.
I can stop here on that PR. Should we split the taiga task also ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants