-
Notifications
You must be signed in to change notification settings - Fork 50
Fix integration tests for Magento_Backend and Magento_Bundle #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
Fix integration tests for Magento_Backend and Magento_Bundle #134
Conversation
dev/tests/integration/testsuite/Magento/Bundle/_files/issaleable_product.php
Show resolved
Hide resolved
dev/tests/integration/testsuite/Magento/Bundle/_files/issaleable_product.php
Outdated
Show resolved
Hide resolved
dev/tests/integration/testsuite/Magento/Bundle/_files/issaleable_product.php
Outdated
Show resolved
Hide resolved
Hi! Just wondering, should we have this be a draft PR for now, while you work on more fixes? Or do you want to split your work into multiple PRs, and have us process this one now as-is? It might be good to do multiple PRs, so that each individual PR is smaller for review. That way we could get things merged faster and more often for you, too. |
Hi @rhoerr , yes of course you're right. Plus i should rewrite the description of the PR since it now contains a few more things. |
Description (*)
I have fixed all integration tests on Magento_Backend and Magento_Bundle. For the first one it was about rewriting the test to adapt it to the class's new dependencies.
For the second one it was about fixing Magento.
I added fixes for the Magento_CatalogInventory module. It was about fixing the integration with the new ParentItemProcessInterface
Fixed Issues (if relevant)
I cannot access github issues on the mage-os repo. So here is the taiga ticket :
Fix all broken integration tests
But the PR for now does not fix all integration tests. it will be a long way to go.
Manual testing scenarios (*)
First make sure you're in the dev/tests/integration folder. then :
You should have 0 broken test
Contribution checklist (*)