Skip to content

Improvements to actions workflows #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sshin23 merged 6 commits into from
Aug 24, 2026
Merged

Improvements to actions workflows #644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f4d01d7
use latest checkout action
apozharski Aug 21, 2026
dec1e9f
no longer use scary permissions and pull_request_target for no reason
apozharski Aug 21, 2026
520fd47
bump comment versions to try to appease the node update warnings
apozharski Aug 21, 2026
032fc57
remove cuda13 label
sshin23 Aug 24, 2026
7b213fc
remove cuda13 label
sshin23 Aug 24, 2026
9f4a0b7
Merge branch 'master' into ap/workflow-improvements
sshin23 Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/DocsCleanup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
contents: write
steps:
- name: Checkout gh-pages branch
uses: actions/checkout@v4
uses: actions/checkout@v7
with:
ref: gh-pages

Expand Down
11 changes: 5 additions & 6 deletions .github/workflows/Format.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
name: 'Format'

on:
pull_request_target:
pull_request:
types: [opened, synchronize, reopened, ready_for_review]

permissions:
contents: read
actions: write
pull-requests: write

jobs:
Expand All @@ -15,7 +14,7 @@ jobs:
if: github.event.pull_request.draft == false
steps:
- name: Check out repository
uses: actions/checkout@v4
uses: actions/checkout@v7
with:
ref: ${{github.event.pull_request.head.ref}}
repository: ${{github.event.pull_request.head.repo.full_name}}
Expand Down Expand Up @@ -57,7 +56,7 @@ jobs:
[ $EXIT_CODE -eq 2 ] && exit 1 || exit 0

- name: Find comment
uses: peter-evans/find-comment@v3
uses: peter-evans/find-comment@v4
id: find-comment
with:
issue-number: ${{ github.event.pull_request.number }}
Expand All @@ -66,7 +65,7 @@ jobs:

- name: Comment formatting suggestions
if: steps.runic.outputs.exit_code == 1
uses: peter-evans/create-or-update-comment@v4
uses: peter-evans/create-or-update-comment@v5
with:
comment-id: ${{ steps.find-comment.outputs.comment-id }}
issue-number: ${{ github.event.pull_request.number }}
Expand All @@ -88,7 +87,7 @@ jobs:

- name: Update stale comment
if: steps.runic.outputs.exit_code == 0 && steps.find-comment.outputs.comment-id
uses: peter-evans/create-or-update-comment@v4
uses: peter-evans/create-or-update-comment@v5
with:
comment-id: ${{ steps.find-comment.outputs.comment-id }}
issue-number: ${{ github.event.pull_request.number }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
build:
runs-on:
- self-hosted
- cuda13
- cuda
steps:
- uses: actions/checkout@v2
- uses: julia-actions/install-juliaup@v2
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ jobs:
fail-fast: false
matrix:
julia-version: ['1']
gpu: [cuda13, amdgpu]
gpu: [cuda, amdgpu]
runs-on:
- self-hosted
- ${{ matrix.gpu }}
Expand All @@ -131,7 +131,7 @@ jobs:
PackageSpec(path="./lib/MadNLPTests"),
])
- name: Add CUDA and CUDSS
if: matrix.gpu == 'cuda13'
if: matrix.gpu == 'cuda'
shell: julia --project=./lib/MadNLPGPU/test --color=yes {0}
run: |
using Pkg
Expand Down
Loading