Skip to content

Set docs.rs targets on all crates#160

Merged
madsmtm merged 2 commits intomasterfrom
tweak-docs-targets
Jun 12, 2022
Merged

Set docs.rs targets on all crates#160
madsmtm merged 2 commits intomasterfrom
tweak-docs-targets

Conversation

@madsmtm
Copy link
Copy Markdown
Owner

@madsmtm madsmtm commented Jun 11, 2022

Tested with local docs.rs instance.

Tier 3 (and below) targets are not yet supported, see rust-lang/docs.rs#1561

@madsmtm madsmtm added documentation Improvements or additions to documentation A-objc2 Affects the `objc2`, `objc2-exception-helper` and/or `objc2-encode` crates A-framework Affects the framework crates and the translator for them A-block2 Affects the `block2` crate labels Jun 11, 2022
@madsmtm madsmtm force-pushed the tweak-docs-targets branch 3 times, most recently from 37bd8bc to 78e7c68 Compare June 12, 2022 05:44
@madsmtm madsmtm force-pushed the tweak-docs-targets branch 3 times, most recently from 8a3b7cc to 3483b93 Compare June 12, 2022 07:03
We only have control over features when we're the crate being compiled, in other cases the parent crate should control which runtime to use, so we can't just check DOCS_RS - otherwise they'll error out because the wrong runtime was selected.
@madsmtm madsmtm force-pushed the tweak-docs-targets branch 2 times, most recently from bb95ac6 to 4041a63 Compare June 12, 2022 07:43
@madsmtm madsmtm marked this pull request as ready for review June 12, 2022 07:43
@madsmtm madsmtm merged commit 0e10639 into master Jun 12, 2022
@madsmtm madsmtm deleted the tweak-docs-targets branch June 12, 2022 08:06
@madsmtm madsmtm mentioned this pull request Jul 7, 2022
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-block2 Affects the `block2` crate A-framework Affects the framework crates and the translator for them A-objc2 Affects the `objc2`, `objc2-exception-helper` and/or `objc2-encode` crates documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant