-
-
Notifications
You must be signed in to change notification settings - Fork 177
Rebased: Added support for basic glob patterns in "inputFile" #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Do you mean "Re-compile all files"? |
Yes, but I've just implemented that. |
2b633d9
to
ae51e91
Compare
ae468b1
to
a944245
Compare
@madskristensen are all these required before merging this PR? |
Hey guys, it is great PR, let merge it!!! We are desire it! |
@madskristensen what needs to be done before this get merged? #199 (comment) was fixed |
There are conflicts that prevents auto-merge. Also, only 1/4 checkboxes in the was checked. What is the plan for these other ones? Is this PR useful without them checked? |
@madskristensen If IDE will show errors in config JSON, or defaults will miss example for new feature - it is nothing important. Let it be as experimental feature, that only can be enabled if you know how. So you will not break product for all users, and last checkbox is not so critical I think. By the way, *.csproj very often have simple merge confilcts - git have pure support for merging xml files... |
Guess this could be closed? (it's in my mentioned list - https://github.com/pulls/mentioned) |
This is rebase of #199 which fixes #69
Items for improvement:
compilerconfig.json
schema validation fails ifoutputFile
is not specifiedcompilerconfig.json
with[{ "inputFile": "*.scss" }]
content, I think it should be assumed? or maybe have an option incompilerconfig.json.defaults
?cc @304NotModified