Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade oneprocess tests in the CI to ubuntu-22.04 because clang-format-18 is not yet supported #1022

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

valassi
Copy link
Member

@valassi valassi commented Oct 12, 2024

Debug github CI issues with clang-format

See https://github.com/madgraph5/madgraph4gpu/actions/runs/11304784032/job/31443586843


+++ Check code formatting in newly generated code ee_mumu.mad

ERROR! clang-format version >= 13 and <= 15 is not installed and /cvmfs/sft.cern.ch/lcg/releases/clang is not reachable
ERROR! mg-clang-format failed
ERROR! Auto-generated code does not respect formatting policies
 
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[testsuite_oneprocess.sh] codegen (ee_mumu.mad) finished with status=1 (NOT OK) at Sat Oct 12 10:07:47 UTC 2024
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
Error: Process completed with exit code 1.

@valassi valassi self-assigned this Oct 12, 2024
@valassi valassi marked this pull request as draft October 12, 2024 11:56
@valassi
Copy link
Member Author

valassi commented Oct 12, 2024

As expected, the version is too recent
https://github.com/madgraph5/madgraph4gpu/actions/runs/11305421978/job/31444906226?pr=1022


ERROR! clang-format version >= 13 and <= 15 is not installed and /cvmfs/sft.cern.ch/lcg/releases/clang is not reachable
ERROR! current clangVersion is '18'
ERROR! mg-clang-format failed
ERROR! Auto-generated code does not respect formatting policies

valassi added a commit to valassi/madgraph4gpu that referenced this pull request Oct 12, 2024
…downgrade ubuntu-latest to ubuntu-22.04 because clang-format-18 is not yet supported (madgraph5#1022)

Note: ubuntu-24.04 images are available since three weeks ago (processone/ejabberd issues/4281)
@valassi valassi changed the title Debug github CI issues with clang-format Downgrade oneprocess tests in the CI to ubuntu-22.04 because clang-format-18 is not yet supported Oct 12, 2024
…ntu-22.04 in the codegen step because clang-format-18 is not yet supported (madgraph5#1022)
@valassi valassi marked this pull request as ready for review October 12, 2024 13:57
@valassi valassi requested a review from a team as a code owner October 12, 2024 13:57
@valassi
Copy link
Member Author

valassi commented Oct 12, 2024

Hi @oliviermattelaer I self merge this because it is trivial and is necessary. All github CI tests fail otherwise.

@valassi valassi merged commit 32a3c69 into madgraph5:master Oct 12, 2024
169 checks passed
valassi added a commit to valassi/madgraph4gpu that referenced this pull request Oct 12, 2024
valassi added a commit to valassi/madgraph4gpu that referenced this pull request Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant