Skip to content

testing destroy #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 50 commits into
base: main
Choose a base branch
from
Open

testing destroy #17

wants to merge 50 commits into from

Conversation

@zeerak-aziz
Copy link
Collaborator

@zeerak-aziz zeerak-aziz commented Apr 30, 2025

This PR finalizes the GitHub Actions setup for Databricks sandbox environments.

Deploy:

  • Triggered on PR to main or sandbox/**
  • Provisions full Databricks sandbox (workspace, VPC, IAM, Unity Catalog, etc.)
  • Uses terraform init, plan, and apply

Destroy:

  • Triggered when PR title contains the word destroy
  • Runs terraform destroy -auto-approve
  • Cleanly tears down all associated AWS + Databricks resources

Secrets managed via GitHub Environments
Full setup and usage instructions added to README

Engineers can now:

  • Spin up isolated sandboxes per branch
  • Tear them down via PR title
  • Work independently with minimal infra overhead

@zeerak-aziz
Fix conflict: keeping sandbox.yml from stash
c8bccbc
@zeerak-aziz
fixing merge
35f8220
@zeerak-aziz
fixing both yml syntax naming conv env {{??
8391ed0
@zeerak-aziz
fixing both yml syntax naming conv env {{??
b73d2c2
@zeerak-aziz
giving sandbox.yml a name
c61578c
@zeerak-aziz
Pull request into main
37b9092
@zeerak-aziz
source ../../
3cd5a50
@zeerak-aziz
env names bob
56413bb
@zeerak-aziz
env names bob
12e3075
@zeerak-aziz
actual access key and secret key
e015436
@zeerak-aziz
debugging stuck tf plan
5d6bac3
@zeerak-aziz
debugging stuck tf plan- az zone
9d12d5b
@zeerak-aziz
debugging stuck tf plan- az zone-tf plan
50c008f
@zeerak-aziz
debugging stuck tf plan- az zone-tf plan
fc6ae90
@zeerak-aziz
tf.vars bob
765f51b
@zeerak-aziz
pr into sandbox/**
f39a885
@zeerak-aziz
pr into sandbox/**
6edf980
@zeerak-aziz
pr into sandbox/**
fc8e609
@zeerak-aziz
pr into sandbox/** and main
9771487
@zeerak-aziz
destroy and deploy yml merged, label=destroy
266cc98
@zeerak-aziz
removing duplicate aws_kms_alias keys
614c315
@zeerak-aziz
variables.tf default key values
c6bb85c
@zeerak-aziz
removed all mentions of aws_kms_alias reverting to 5259bd d545dfa
1f5a1d3
@zeerak-aziz
removed all mentions of aws_kms_alias reverting to 5259bd d545dfa, .mws
2067110
@zeerak-aziz
pull_request_trigger
474fa9a
@zeerak-aziz
KISS version, if contains destroy- testing destroy
2480292
@zeerak-aziz
KISS version, if contains destroy- testing destroy
cfa4c5a
@zeerak-aziz
KISS version, if contains destroy- testing destroy again
0f9c5bf
@zeerak-aziz
tf destroy one line KISS
3fb72fb
@zeerak-aziz
tf destroy one line KISS
8eac0a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@menacingplanet86 menacingplanet86 Awaiting requested review from menacingplanet86 menacingplanet86 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zeerak-aziz