removed error printouts. added to_hash methods#23
Open
poulh wants to merge 2 commits intomaddox:masterfrom
Open
removed error printouts. added to_hash methods#23poulh wants to merge 2 commits intomaddox:masterfrom
poulh wants to merge 2 commits intomaddox:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Great gem!
I have a command line tool that uses http_party under the hood and outputs some JSON. the 'invalid date' error messages in episode and series were causing my stdout to be invalid as they mixed in with the JSON. would you be ok if we removed them?
I also added to_hash methods to make it easier to convert the objects to JSON.
Finally, on rubygems.org tvdb_party is at 0.8.1 but I could only find 0.8.0 on your github page. Did I fork from the wrong place? Let me know and I'll redo the pull request.
Thanks!
-poul