Fix: Backend package.json name mismatch#135
Open
Xenon010101 wants to merge 2 commits into
Open
Conversation
Closes madanrajsagar#63 Stored idToken in req.user within verifyToken middleware (both Firebase Admin SDK and REST API paths) and replaced 3 redundant re-extractions in profile lookup, profile update, and account delete handlers. Signed-off-by: Xenon010101 <xenon010101@users.noreply.github.com>
Closes madanrajsagar#71 Renamed from safeguard-backend to abhaya-backend to match the project name. Signed-off-by: Xenon010101 <xenon010101@users.noreply.github.com>
|
Thank you for addressing this issue. I noticed that the PR also includes a commit related to Bearer token extraction in the auth route in addition to the package name fix. Would it be better to keep these changes in separate PRs so that each PR addresses a single issue and is easier to review and maintain? Looking forward to the maintainers' feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #71
Root cause:
backend/package.json:2named the packagesafeguard-backendwhile the project is called Abhaya.Fix: Renamed to
abhaya-backendto match the project name.