Fix: Auth route re-extracts Bearer token redundantly#134
Open
Xenon010101 wants to merge 1 commit into
Open
Conversation
Closes madanrajsagar#63 Stored idToken in req.user within verifyToken middleware (both Firebase Admin SDK and REST API paths) and replaced 3 redundant re-extractions in profile lookup, profile update, and account delete handlers. Signed-off-by: Xenon010101 <xenon010101@users.noreply.github.com>
Author
|
👋 Hi! Following up on this PR. Let me know if anything needs to be changed or if there's more context needed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #63
Root cause: Three handlers in
backend/routes/auth.js(profile lookup at line 575, profile update at line 679, account delete at line 746) re-extracted the Bearer token fromreq.headers.authorizationeven thoughverifyTokenalready extracted and verified it.Fix: Stored the raw
idTokeninreq.user.idTokenwithin theverifyTokenmiddleware (in both Firebase Admin SDK and REST API paths). Updated the three handlers to usereq.user.idTokeninstead of re-parsing headers.