fix: inline checkSession into useEffect to fix stale closure#114
Open
kush-mehra1 wants to merge 1 commit into
Open
fix: inline checkSession into useEffect to fix stale closure#114kush-mehra1 wants to merge 1 commit into
kush-mehra1 wants to merge 1 commit into
Conversation
Author
|
GSSOC 2026 contribution. could a maintainer add the gssoc:approved label and a difficulty level? thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #72
AuthContext.checkSession referenced in useEffect with empty deps — the closure captures a stale reference. Inlined the check into useEffect directly so the effect has the actual function body.
GSSOC 2026 contribution