Drops Java <16 constraint from pretty_format_kotlin

[harti2006]

Fixes #122

[codecov]

Codecov Report

Merging #123 (52563e6) into master (d9072eb) will not change coverage.
The diff coverage is n/a.

❗ Current head 52563e6 differs from pull request most recent head cf95f11. Consider uploading reports for the commit cf95f11 to get more accurate results

@@            Coverage Diff            @@
##            master      #123   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          305       303    -2     
=========================================
- Hits           305       303    -2     

Impacted Files	Coverage Δ
...ormatters_pre_commit_hooks/pretty_format_kotlin.py	100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[macisamuele]

Please remove test annotations such that we will know if all test passes.
Once test are green I'll be happy to merge and release this.

@harti2006 thanks for preparing the PR

Please rebase the changes on top of 07944ad as it fixes some possible pre-commit failures.

[harti2006]

Since I removed the test annotations, I'd also like to show that the tool works with even more recent Java versions than 17

[whiskeysierra]

Test fails with:

Caused by: java.lang.reflect.InaccessibleObjectException:
Unable to make field private transient java.lang.Object
java.lang.Throwable.backtrace accessible:
module java.base does not "opens java.lang" to unnamed module @28c71909

Sounds related to:

• ktlint fails on Java 16+ pinterest/ktlint#1195 (comment)
• https://youtrack.jetbrains.com/issue/KT-51619
• java.lang.reflect.InaccessibleObjectException: Unable to make field private transient java.lang.Object java.lang.Throwable.backtrace accessible: module java.base does not "opens java.lang" to unnamed module @76628072 pinterest/ktlint#1391 (comment)

[whiskeysierra]

It's probably safe to add --add-opens ... to the java process arguments.

[harti2006]

Tried it like this:

language-formatters-pre-commit-hooks/language_formatters_pre_commit_hooks/pretty_format_kotlin.py

Lines 62 to 70 in 2afa43c

	opens_java_lang = ["--add-opens", "java.base/java.lang=ALL-UNNAMED"]
	# ktlint does not return exit-code!=0 if we're formatting them.
	# To workaround this limitation we do run ktlint in check mode only,
	# which provides the expected exit status and we run it again in format
	# mode if autofix flag is enabled
	check_status, check_output = run_command(
	"java", "-jar", ktlint_jar, "--verbose", "--relative", *opens_java_lang, "--", *_fix_paths(args.filenames)
	)

[harti2006]

The first attempt did not work. The args were parsed by the Ktlint application, rather than the "java" command itself. Trying to move them earlier

[macisamuele]

Thanks for the effort on making new JDK available to the tool.

If tests are green this will be merged and within EOD I will release the new version of the pre-commit hooks.