Cherry pick Helix style config - #67
Merged
Merged
Conversation
Refactor hardcoded switch statements into action-based dispatch with per-mode keymaps. Users can override bindings via $XDG_CONFIG_HOME/sheets/config.toml using [keys.normal], [keys.insert], and [keys.select] tables. Set a key to "nop" to disable it.
Clear selected cells without affecting clipboard/registers. Default bound to D in select mode. Complements cut_selection (x) which yanks before clearing.
When g is pressed, all visible cells show their coordinates (column letters in blue, row numbers in yellow) centered over dimmed cell content. Typing filters matches live — matched chars dim, unmatched stay bright. Auto-selects when one visible cell remains. Fully matched cells show ⏎ symbol to indicate enter confirmation. Visual indicators: GOTO mode label in status bar, dimmed grid borders, colored row/column headers for matching axes, input prompt at bottom.
# Conflicts: # internal/sheets/normal_mode.go
autoSelectGoto finalized on a unique visible match, killing the overlay before it ever rendered — the integration test encoded the intended UX (persistent gA5 label, next non-ref key exits and acts). Jump still happens live; escape/enter/other keys end the pending state. Unskips the April integration test.
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.