Merge pull request #7 from spk/tests

Add test

Rakefile

@@ -1 +1,9 @@
 require 'bundler/gem_tasks'
+require 'rake/testtask'
+
+task default: [:test]
+
+Rake::TestTask.new do |t|
+  t.pattern = 'test/**/*_test.rb'
+end
+task spec: :test

lib/rubocop/git/options.rb

@@ -72,7 +72,8 @@ def commit_last
       def from_hash(hash_options)
         hash_options = hash_options.dup
         %w(config cached hound rubocop commits).each do |key|
-          public_send("#{key}=", hash_options.delete(key))
+          value = hash_options.delete(key) || hash_options.delete(key.to_sym)
+          public_send("#{key}=", value)
         end
         unless hash_options.empty?
           fail Invalid, "invalid keys: #{hash_options.keys.join(' ')}"

lib/rubocop/git/runner.rb

@@ -11,7 +11,7 @@ def run(options)
         @files = DiffParser.parse(git_diff(options))
 
         display_violations($stdout)
-        
+
         exit(1) if violations.any?
       end
 

rubocop-git.gemspec

@@ -20,6 +20,7 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency 'bundler', '~> 1.6'
   spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'minitest'
 
   spec.add_dependency 'rubocop', '>= 0.24.1'
 end

test/rubocop/git/cli_test.rb

@@ -0,0 +1,12 @@
+require_relative '../../test_helper'
+require 'rubocop/git/cli'
+
+describe RuboCop::Git::CLI do
+  it 'fail with invalid options' do
+    proc do
+      _out, _err = capture_io do
+        RuboCop::Git::CLI.new.run(['--gruß'])
+      end
+    end.must_raise(SystemExit)
+  end
+end

test/rubocop/git/options_test.rb

@@ -0,0 +1,18 @@
+require_relative '../../test_helper'
+require 'rubocop/git/options'
+
+describe RuboCop::Git::Options do
+  it 'fail with no options' do
+    proc do
+      RuboCop::Git::Options.new({})
+    end.must_raise(RuboCop::Git::Options::Invalid)
+  end
+
+  it 'can pass string hash options' do
+    RuboCop::Git::Options.new('rubocop' => {}, 'commits' => [])
+  end
+
+  it 'can pass symbol hash options' do
+    RuboCop::Git::Options.new(rubocop: {}, commits: [])
+  end
+end

test/rubocop/git/runner_test.rb

@@ -0,0 +1,23 @@
+require_relative '../../test_helper'
+require 'rubocop/git/runner'
+
+describe RuboCop::Git::Runner do
+  it 'exit with violations' do
+    options = RuboCop::Git::Options.new
+    # lib/rubocop/git/runner.rb:14:1: C: Trailing whitespace detected.
+    options.commits = ["v0.0.4", "v0.0.5"]
+    proc do
+      _out, _err = capture_io do
+        RuboCop::Git::Runner.new.run(options)
+      end
+    end.must_raise(SystemExit)
+  end
+
+  it 'fail with no options' do
+    proc do
+      _out, _err = capture_io do
+        RuboCop::Git::Runner.new.run({})
+      end
+    end.must_raise(RuboCop::Git::Options::Invalid)
+  end
+end

test/test_helper.rb

@@ -0,0 +1,2 @@
+require 'minitest/autorun'
+require 'rubocop/git'