finish assignment_1

[lyuxiaotian]

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

knn model

What did you learn from the changes you have made?

after finding the best k, need to teach the model all over again

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

• I can confirm that my changes are working as intended

[PatelVishakh]

Assignment 1: Complete. Great work!
Suggested Changes:

Q1)III) The type of variable is categorical. In a data science setting, this question is asking whether the variable is continuous or categorial(integer, ordinal are other options).

Q2)I)The more accurate explanation is that Variables with large scales can cause the model bias towards only being influenced by those variables.

Q3)II)range(1:51) as python doesn’t include last index, also no need to do skip since our grid is not very big.