Rev2

[anjalidk]

STAT code fixes.

[hallyn]

I still prefer this be an snprintf. This is outside the 3 lines of usual patch context of the buf[36] definition, so a future patch could cause trouble that we wouldn't catch.

[anjalidk]

Submitted rev3 instead.

[anjalidk]

On Oct 20, 2023, at 4:58 PM, Serge Hallyn ***@***.***> wrote: @hallyn approved this pull request. In stat.c: > +#include <errno.h> +#include <libgen.h> +#include "stat.h" + +static char buffer[9000]; + +static int populate_statcpu(struct cpu_stat *all_cpu, int cpu_num) +{ + char buf[36]; + const char *cstr; + + if (!all_cpu) { + return -1; + } + for (int i = 0; i < cpu_num; i++) { + sprintf(buf, "cpu%d", i); I still prefer this be an snprintf. This is outside the 3 lines of usual patch context of the buf[36] definition, so a future patch could cause trouble that we wouldn't catch.

Thanks, fixed this and submitted in new branch rev3 (with the last 2 commits in rev2 merged as one) & created new pull. Somehow, the old one didn’t have all earlier the commits in it. Anjali

…

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>