Fixes for Windows 11 24H2 driver injection #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When injecting drivers for Windows 11 24H2, there can be a conflict with an existing "oem0.inf" file from C:\WINDOWS\System32\DriverStore\FileRepository\vmci.inf_amd64_72a1c95f9120db75\. In the case of the NetKVM driver, this will prevent it from being properly installed. To work around this, adjust the name of the inf files installed so they won't conflict with any existing ones. Signed-off-by: Mathias Gibbens <[email protected]>
The NetKVM driver depends on starting a service when it is installed. Without the corresponding exes, this will fail, so also install any relevant exes when injecting the driver. Signed-off-by: Mathias Gibbens <[email protected]>
gibmat
commented
Oct 25, 2024
| @@ -489,7 +489,7 @@ func (c *cmdRepackWindows) injectDrivers(infDir, driversDir, filerepositoryDir, | |||
| softwareRegistry := "Windows Registry Editor Version 5.00" | |||
| for driverName, driverInfo := range windows.Drivers { | |||
| logger.WithField("driver", driverName).Debug("Injecting driver") | |||
| infFilename := fmt.Sprintf("oem%d.inf", i) | |||
| infFilename := fmt.Sprintf("oem-virtio-incus%d.inf", i) | |||
There was a problem hiding this comment.
I don't know if there are any "magical" assumptions about the inf files being named "oemX.inf", but driver installation seemed to continue working properly with the renamed inf files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two issues when injecting drivers into an installed Windows 11 24H2 system: