Skip to content

snmp: verify return status to avoid using uninitialized variables #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

snmp: verify return status to avoid using uninitialized variables #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ae6735
verify return value of etharp_get_entry()
Feb 10, 2025
9df42f0
verify return value of snmpv3_get_user()
Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/apps/snmp/snmp_mib2_ip.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,9 @@ ip_NetToMediaTable_get_cell_value_core(size_t arp_table_index, const u32_t *colu
struct netif *netif;
struct eth_addr *ethaddr;

etharp_get_entry(arp_table_index, &ip, &netif, &ethaddr);
if(!etharp_get_entry(arp_table_index, &ip, &netif, &ethaddr)) {
return SNMP_ERR_NOSUCHINSTANCE;
}

/* value */
switch (*column) {
Expand Down
10 changes: 8 additions & 2 deletions src/apps/snmp/snmp_snmpv2_usm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,10 @@ static s16_t usmusertable_get_value(struct snmp_node_instance *cell_instance, vo
case 5: { /* usmUserAuthProtocol */
const struct snmp_obj_id *auth_algo;
snmpv3_auth_algo_t auth_algo_val;
snmpv3_get_user((const char *)cell_instance->reference.ptr, &auth_algo_val, NULL, NULL, NULL);
if(snmpv3_get_user((const char *)cell_instance->reference.ptr, &auth_algo_val, NULL, NULL, NULL) != ERR_OK) {
LWIP_DEBUGF(SNMP_MIB_DEBUG, ("usmusertable_get_value(): not found user: %s\n", (const char *)cell_instance->reference.ptr));
return 0;
}
auth_algo = snmp_auth_algo_to_oid(auth_algo_val);
MEMCPY(value, auth_algo->id, auth_algo->len * sizeof(u32_t));
return auth_algo->len * sizeof(u32_t);
Expand All @@ -302,7 +305,10 @@ static s16_t usmusertable_get_value(struct snmp_node_instance *cell_instance, vo
case 8: { /* usmUserPrivProtocol */
const struct snmp_obj_id *priv_algo;
snmpv3_priv_algo_t priv_algo_val;
snmpv3_get_user((const char *)cell_instance->reference.ptr, NULL, NULL, &priv_algo_val, NULL);
if(snmpv3_get_user((const char *)cell_instance->reference.ptr, NULL, NULL, &priv_algo_val, NULL) != ERR_OK) {
LWIP_DEBUGF(SNMP_MIB_DEBUG, ("usmusertable_get_value(): not found user: %s\n", (const char *)cell_instance->reference.ptr));
return 0;
}
priv_algo = snmp_priv_algo_to_oid(priv_algo_val);
MEMCPY(value, priv_algo->id, priv_algo->len * sizeof(u32_t));
return priv_algo->len * sizeof(u32_t);
Expand Down