Make text overview truncation UTF-8 safe#216
Merged
Merged
Conversation
Owner
Author
Quality Gatekeeper Review\nVerdict: NEEDS_CHANGES\nRisk: Low\nLane: product\n\nChecks:\n- [x] Scope is clear\n- [x] Protected files unchanged\n- [x] No secret/session/prompt leakage visible in the patch\n- [x] No public platform-attention target wording visible in the patch\n- [ ] Acceptance criteria complete\n- [ ] Full local review completed\n\nNotes:\nThis PR appears to implement #215, but the current patch only updates the shared textCell helper. The #215 checkpoint already identified the remaining gap: the recent anomalies text row still uses byte slicing for session names, so long non-ASCII anomaly names can still be truncated on an invalid UTF-8 boundary. The current regression test also exercises the helper directly, not the full ReportOverview recent-anomalies path.\n\nDecision:\nKeep this as NEEDS_CHANGES. Please update the recent anomalies truncation path to use the UTF-8-safe helper, add/extend a ReportOverview regression with a long non-ASCII anomaly session name, and relabel as status/ready-for-review after rerunning test/build/report checks.\n\nHandoff to: Product implementation. |
Owner
Author
|
Event: Quality checkpoint Evidence:
Requested adjustment before this can be ready for review:
|
Owner
Author
|
Event: Post-merge checkpoint Evidence: PR #216 merged as Remaining gap: #215 is still open because |
This was referenced May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation