Guard static demo report semantics

[luoyuctl]

Summary

• tighten check-pages-artifact.sh so site/demo-report.html must expose current report evidence markers or explicitly identify static sample data
• require local-first/no-upload wording when the static sample path is used
• mark the committed static demo report as static sample data without changing generated report behavior

Fixes #207

Test plan

• go test ./...
• go build -o /tmp/agenttrace-quality-207 ./cmd/agenttrace
• /tmp/agenttrace-quality-207 --doctor || true
• /tmp/agenttrace-quality-207 --demo --overview -f json >/tmp/agenttrace-quality-207-demo.json
• AGENTTRACE_BIN=/tmp/agenttrace-quality-207 AGENTTRACE_CI_OUT=/tmp/agenttrace-quality-207-ci-output scripts/ci/check-output-contract.sh
• AGENTTRACE_BIN=/tmp/agenttrace-quality-207 AGENTTRACE_CI_OUT=/tmp/agenttrace-quality-207-ci-deterministic scripts/ci/check-deterministic-output.sh
• AGENTTRACE_BIN=/tmp/agenttrace-quality-207 AGENTTRACE_CI_OUT=/tmp/agenttrace-quality-207-ci-semantics scripts/ci/check-report-semantics.sh
• scripts/ci/check-release-surfaces.sh
• AGENTTRACE_BIN=/tmp/agenttrace-quality-207 AGENTTRACE_CI_OUT=/tmp/agenttrace-quality-207-ci-docs scripts/ci/check-docs-commands.sh
• scripts/ci/check-pages-artifact.sh site
• negative smoke: remove static sample paragraph from a temp copy of site/demo-report.html; scripts/ci/check-pages-artifact.sh fails with the expected semantic guard message
• git diff --check

[luoyuctl]

Event: Validation / Decision
Actor: Product
Scope: PR #208 / Issue #207
State change: Issue #207 should move from status/in-progress to status/ready-for-review
Evidence: Reviewed branch head 7dc8de5; diff is limited to scripts/ci/check-pages-artifact.sh and site/demo-report.html. GitHub CI Test and build is SUCCESS and mergeStateStatus is CLEAN. Local Product validation already passed scripts/ci/check-pages-artifact.sh site, go build, and scripts/ci/check-report-semantics.sh with AGENTTRACE_BIN pointed at the built binary.
Next owner: Quality / Maintainer review

Decision: Product acceptance is satisfied pending normal review/merge. The PR keeps the generated-report semantic contract separate from static Pages artifact checks, avoids live local totals, and uses a static-sample/local-first disclosure instead of overstating current generated report content.

Acceptance check after merge: #207 should close via Closes #207; post-merge validation should rerun Pages artifact and report semantics checks on master.

[luoyuctl]

Quality Gatekeeper Review

Verdict: PASS
Risk: Low
Lane: quality
Checks:

• One logical change
• Scope is clear
• Protected files unchanged
• No secret/session/prompt leakage
• No public platform-attention target wording
• go test ./... passed
• go build passed
• doctor/demo overview passed
• Docs/tests updated if needed

Notes:

• GitHub mergeStateStatus: CLEAN; mergeable: MERGEABLE.
• GitHub CI: Test and build passed.
• Changed files: scripts/ci/check-pages-artifact.sh, site/demo-report.html. No protected files changed.
• Local review worktree: ../agenttrace-review-pr-208 from pr-208, removed after validation.
• Validation commands:
  • go test ./...
  • go build -o /tmp/agenttrace-review-pr-208 ./cmd/agenttrace
  • git diff --check origin/master...HEAD
  • /tmp/agenttrace-review-pr-208 --doctor || true
  • /tmp/agenttrace-review-pr-208 --demo --overview -f json >/tmp/agenttrace-review-pr-208-demo.json
  • AGENTTRACE_BIN=/tmp/agenttrace-review-pr-208 AGENTTRACE_CI_OUT=/tmp/agenttrace-review-pr-208-ci-output scripts/ci/check-output-contract.sh
  • AGENTTRACE_BIN=/tmp/agenttrace-review-pr-208 AGENTTRACE_CI_OUT=/tmp/agenttrace-review-pr-208-ci-deterministic scripts/ci/check-deterministic-output.sh
  • AGENTTRACE_BIN=/tmp/agenttrace-review-pr-208 AGENTTRACE_CI_OUT=/tmp/agenttrace-review-pr-208-ci-semantics scripts/ci/check-report-semantics.sh
  • scripts/ci/check-release-surfaces.sh
  • AGENTTRACE_BIN=/tmp/agenttrace-review-pr-208 AGENTTRACE_CI_OUT=/tmp/agenttrace-review-pr-208-ci-docs scripts/ci/check-docs-commands.sh
  • scripts/ci/check-pages-artifact.sh site
  • negative smoke on a temp Pages copy without the static sample paragraph: failed with demo-report.html must include current report evidence markers or clearly identify static sample data

Decision: PASS. The PR adds a narrow deterministic Pages artifact guard and keeps the committed static sample explicitly local-first without changing generated report behavior.

[luoyuctl]

Event: Validation
Actor: Product
Scope: PR #208 negative/positive guard check
State change: none
Evidence: Added a Product-side negative validation for the Pages guard:

• Positive branch check passed: scripts/ci/check-pages-artifact.sh site
• Generated-report semantic contract still passed: go build -o /tmp/agenttrace-product-208-check ./cmd/agenttrace and AGENTTRACE_BIN=/tmp/agenttrace-product-208-check AGENTTRACE_CI_OUT=/tmp/agenttrace-product-208-ci scripts/ci/check-report-semantics.sh
• Negative check: copied the branch to /tmp/agenttrace-product-208-negative, removed the static sample disclaimer from site/demo-report.html, and reran scripts/ci/check-pages-artifact.sh site; it failed as expected with demo-report.html must include current report evidence markers or clearly identify static sample data.
  Next owner: Quality / Maintainer review

Product read: this confirms the new guard catches the stale-static-report shape without relying on live local session totals or duplicating the generated-report semantic suite.